Repository navigation
General implementation profile page - #36426
Conversation
# Conflicts: # src/components/Icon/Illustrations.ts # src/libs/API/parameters/index.ts # src/libs/Navigation/linkingConfig/CENTRAL_PANE_TO_RHP_MAPPING.ts # src/libs/Navigation/types.ts # src/pages/workspace/WorkspacePageWithSections.tsx # src/types/onyx/Form.ts
# Conflicts: # src/ONYXKEYS.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/onyx/Form.ts # src/types/onyx/index.ts
# Conflicts: # src/ROUTES.ts # src/libs/Navigation/AppNavigator/ModalStackNavigators.tsx # src/libs/actions/Policy.ts # src/pages/workspace/WorkspaceProfilePage.js # src/types/form/index.ts
# Conflicts: # src/libs/API/parameters/index.ts
|
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@allroundexperts is around to review this now so we can keep moving! |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen.Recording.2024-02-15.at.6.09.20.PM.movAndroid: mWeb ChromeScreen.Recording.2024-02-15.at.6.07.42.PM.moviOS: NativeScreen.Recording.2024-02-15.at.6.01.10.PM.moviOS: mWeb SafariScreen.Recording.2024-02-15.at.5.59.28.PM.movMacOS: DesktopScreen.Recording.2024-02-15.at.5.57.08.PM.mov |
|
BUG Screen.Recording.2024-02-15.at.6.01.56.PM.mov |
|
@allroundexperts appreciated for review! Fixed all items you mentioned above |
|
@narefyev91 Was this fixed as well? |
Yup! Screen.Recording.2024-02-15.at.16.20.34.mov |
luacmartins
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this!
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Wahooo -- one down! |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.43-0 🚀
|
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀
|
| imageStyles={[styles.avatarXLarge, styles.alignSelfCenter]} | ||
| source={policy.avatar ? policy.avatar : ReportUtils.getDefaultWorkspaceAvatar(policyName)} | ||
| fallbackIcon={Expensicons.FallbackWorkspaceAvatar} | ||
| <ScrollView> |
There was a problem hiding this comment.
@narefyev91 can you confirm nested ScrollView here is intentional?
I think it's redundant as shouldUseScrollView prop was already passed to WorkspacePageWithSections.
We wanna remove this in #38248 but just to double confirm to avoid regression.
There was a problem hiding this comment.
Hey - it was added to scroll profile page on small devices. But if after removing nested ScrollView - it will work - fully fine with that. Thanks!








Details
Implement General implementation of Profile page, Description page from the Simplified Collect: Profile, Members, Categories design doc
Images for references: (Share button will be introduced in other GH issue)
Fixed Issues
$ #35719
PROPOSAL: #35719
Tests
Open workspace as Admin:
Open workspace in which user joined (but not have the role - Admin):
Offline tests
Open workspace as Admin:
Open workspace in which user joined (but not have the role - Admin):
QA Steps
Open workspace as Admin:
Open workspace in which user joined (but not have the role - Admin):
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
android-web.mov
iOS: Native
ios.mov
iOS: mWeb Safari
ios-web.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov